Add support for Tornado 16X SQ air conditioner (0x4E2A) #520

felipediel · 2021-01-22T22:57:06Z

This PR is based on @enosh's work: #430. I was helping with the review and the PR ended up getting lost in the midst of so many changes and updates. He was being very cooperative, so I think now is the time for me to do my part. I rebased and cleaned up the code a little bit to have it merged soon.

This is a work in progress.

Todo

felipediel · 2021-01-23T06:42:05Z

Hi @enosh. I rebased so it doesn't get lost in time. Still work? I wish we could have this in v0.17.0, because I don't know how many chances we will have after that.

enosh · 2021-05-02T11:02:13Z

Hey, been away for a while, this looks very neat.
I did some testing, and found out some packet length issues but other than that everything works well.

As for the interface, I think the only remaining question is whether to add a function that sets only part of the state and retrieves the rest. The user can do this on their own but it's a nice to have.

Also isolated the "ifeel" option.

Since I can't push to your branch I put the commit here.

enosh · 2021-05-02T11:30:20Z

broadlink/climate.py

+        s = sum([v if i % 2 == 0 else v << 8 for i, v in enumerate(data)])
+        # trim the overflow and add it to smallest bit
+        s = (s & 0xffff) + (s >> 16)
+        return (0xffff - s)  # TODO: fix: we can't return negative values


I might be misunderstanding what you mean.

But if you mean be negative like in the screenshot, I think it'd be okay just to check that the packet is smaller than 2^18B.

Yes, overflow is unlikely as we are not dealing with packets of this size. & 0xFFFF should be enough as a safeguard:

return (0xffff - s) & 0xffff

I just found the polynomial, now we can do:

crc = CRC16.calculate(payload[0x02:p_len], polynomial=0x9BE4)

danielchalmers · 2022-07-26T20:14:44Z

I have AUX Mini Split Air Conditioners with the same type that also can be controlled by AC Freedom

>python broadlink_discovery
Discovering...
###########################################
Unknown
# broadlink_cli --type 0x4e2a --host 192.168.1.61 --mac c8f7____7d8b
Device file data (to be used with --device @filename in broadlink_cli) :
0x4e2a 192.168.1.61 c8f7____7d8b

###########################################
Unknown
# broadlink_cli --type 0x4e2a --host 192.168.1.29 --mac a043____4a0d
Device file data (to be used with --device @filename in broadlink_cli) :
0x4e2a 192.168.1.29 a043____4a0d

I'd be more than happy to help test this if you have the time to rebase it in the future. Would love to see support for these devices!

manio · 2023-08-24T09:31:17Z

Hi,
I own Ande unit. I am currently using it via AC Freedom app. It is 0x4e2a.
Every opensource software I was trying so far, to communicate with this device fails with authentication failure.

I was trying this PR, here is my testing snippset:

#!/usr/bin/python
import broadlink

devices = broadlink.discover(timeout=5)
print(devices)
devices[0].auth()

and as the result:

[<hvac: Licensed manufacturer HVAC (0x4e2a) at [REDACTED]:80 | [REDACTED] | 奥克斯空调 | Locked>]
Traceback (most recent call last):
  File "/usr/src/klima-testy/python-broadlink/./monitor.py", line 6, in <module>
    devices[0].auth()
  File "/usr/src/klima-testy/python-broadlink/broadlink/device.py", line 167, in auth
    check_error(response[0x22:0x24])
  File "/usr/src/klima-testy/python-broadlink/broadlink/exceptions.py", line 137, in check_error
    raise exception(error_code)
broadlink.exceptions.AuthenticationError: [Errno -1] Authentication failed

Do you have any clue why is that?

Edit/Update:

I had to remove the device from "AC Freedom" app (using method: liaan/broadlink_ac_mqtt#76 (comment)), then it is unlocked:

[<hvac: Licensed manufacturer HVAC (0x4e2a) at [REDACTED]:80 | [REDACTED] | 奥克斯空调 | Unlocked>]

@liaan

This commits add a new type of supported devices, which is air conditioners. I was testing this only on my specific device but I think that the code should also work with other compatible air conditioners. The device was controlled using `AC Freedom` app: https://play.google.com/store/apps/details?id=com.broadlink.acfreedom I was searching for opensource projects for controlling the device but it is not as popular as the IR blasters or other components, so finally I put the pieces together mainly from two projects: https://github.com/liaan/broadlink_ac_mqtt and this not-yet-merged PR: mjg59/python-broadlink#520 so the credits goes to: @liaan and @mjg59

@liaan

This commits add a new type of supported devices, which is air conditioners. I was testing this only on my specific device but I think that the code should also work with other compatible air conditioners. The device was controlled using `AC Freedom` app: https://play.google.com/store/apps/details?id=com.broadlink.acfreedom I was searching for opensource projects for controlling the device but it is not as popular as the IR blasters or other components, so finally I put the pieces together mainly from two projects: https://github.com/liaan/broadlink_ac_mqtt and this not-yet-merged PR: mjg59/python-broadlink#520 so the credits goes to: @liaan and @felipediel / @mjg59

@liaan

This commits add a new type of supported devices, which is air conditioners. I was testing this only on my specific device but I think that the code should also work with other compatible air conditioners. The device was controlled using `AC Freedom` app: https://play.google.com/store/apps/details?id=com.broadlink.acfreedom I was searching for opensource projects for controlling the device but it is not as popular as the IR blasters or other components, so finally I put the pieces together mainly from two projects: https://github.com/liaan/broadlink_ac_mqtt and this not-yet-merged PR: mjg59/python-broadlink#520 so the credits goes to: @liaan and @felipediel / @mjg59

@liaan

This commits add a new type of supported devices, which is air conditioners. I was testing this only on my specific device but I think that the code should also work with other compatible air conditioners. The device was controlled using `AC Freedom` app: https://play.google.com/store/apps/details?id=com.broadlink.acfreedom I was searching for opensource projects for controlling the device but it is not as popular as the IR blasters or other components, so finally I put the pieces together mainly from two projects: https://github.com/liaan/broadlink_ac_mqtt and this not-yet-merged PR: mjg59/python-broadlink#520 so the credits goes to: @liaan and @felipediel / @mjg59

thewh1teagle · 2023-12-18T22:59:36Z

Any update on this? does the library supports tornado ACs?

felipediel · 2024-04-17T05:06:25Z

Great, I believe we're all set now. Thank you very much, @enosh, and I apologize for the delay. You did a great job!

felipediel marked this pull request as draft January 22, 2021 22:58

felipediel mentioned this pull request Jan 22, 2021

Add initial support for Tornado 16X SQ air conditioner (0x4e2a) #430

Closed

felipediel force-pushed the hvac-support branch 2 times, most recently from 0890deb to acddf5f Compare January 23, 2021 02:46

felipediel force-pushed the dev branch from 0457d50 to 4dfda47 Compare January 23, 2021 03:14

felipediel force-pushed the hvac-support branch from acddf5f to 1c9fbb5 Compare January 23, 2021 03:17

felipediel force-pushed the dev branch from f78e6f0 to e12fd6f Compare January 29, 2021 21:23

felipediel added 9 commits January 29, 2021 18:26

Add support for Tornado 16X SQ air conditioner

f02c9ab

Make Tornado a generic HVAC class

f4707c0

Better names

32d7186

Clean up IntEnums

1d357e2

Clean up encoders

179133c

Fix indexes

9a366e5

Improve set_state() interface

34c95a6

Enumerate presets

0e44f71

Rename state to power in get_ac_info()

1ef9eec

felipediel force-pushed the hvac-support branch from 59a308e to 1ef9eec Compare January 29, 2021 21:27

enosh reviewed May 2, 2021

View reviewed changes

danielchalmers mentioned this pull request Jul 26, 2022

Add support for 0x4e2a aka VOX electronics IVA5-12JR wall mounted AC #608

Open

felipediel added 2 commits April 17, 2024 00:12

Merge remote-tracking branch 'upstream/dev' into hvac-support

855254e

Paint it black

bcde9f6

felipediel added 4 commits April 17, 2024 01:10

Use CRC16 helper class

d97f887

Remove log messages

f840d5d

Fix bugs

fbc0f01

Return state in set_state()

b07de4c

felipediel marked this pull request as ready for review April 17, 2024 05:03

felipediel merged commit 1e11558 into mjg59:dev Apr 17, 2024
4 checks passed

felipediel added the feature label Apr 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Tornado 16X SQ air conditioner (0x4E2A) #520

Add support for Tornado 16X SQ air conditioner (0x4E2A) #520

felipediel commented Jan 22, 2021 •

edited

Loading

felipediel commented Jan 23, 2021 •

edited

Loading

enosh commented May 2, 2021 •

edited

Loading

enosh May 2, 2021

felipediel Apr 12, 2024

felipediel Apr 17, 2024

danielchalmers commented Jul 26, 2022

manio commented Aug 24, 2023 •

edited

Loading

thewh1teagle commented Dec 18, 2023

felipediel commented Apr 17, 2024

Add support for Tornado 16X SQ air conditioner (0x4E2A) #520

Add support for Tornado 16X SQ air conditioner (0x4E2A) #520

Conversation

felipediel commented Jan 22, 2021 • edited Loading

Todo

felipediel commented Jan 23, 2021 • edited Loading

enosh commented May 2, 2021 • edited Loading

enosh May 2, 2021

Choose a reason for hiding this comment

felipediel Apr 12, 2024

Choose a reason for hiding this comment

felipediel Apr 17, 2024

Choose a reason for hiding this comment

danielchalmers commented Jul 26, 2022

manio commented Aug 24, 2023 • edited Loading

Edit/Update:

thewh1teagle commented Dec 18, 2023

felipediel commented Apr 17, 2024

felipediel commented Jan 22, 2021 •

edited

Loading

felipediel commented Jan 23, 2021 •

edited

Loading

enosh commented May 2, 2021 •

edited

Loading

manio commented Aug 24, 2023 •

edited

Loading